Repository navigation
feat(conflict): Add the Tango conflict analyzer - #885
Merged
manjari25 merged 5 commits intoOct 20, 2026
Merged
Conversation
manjari25
added this pull request to stack #883
October 16, 2026 22:30
manjari25
marked this pull request as ready for review
October 16, 2026 22:36
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 16, 2026 22:36
manjari25
force-pushed
the
manjari/tango-analyzer-core
branch
from
October 20, 2026 21:52
0bdff82 to
033fd29
Compare
behinddwalls
approved these changes
Oct 20, 2026
manjari25
force-pushed
the
manjari/tango-analyzer-core
branch
from
October 20, 2026 22:27
033fd29 to
2f737df
Compare
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 20, 2026
behinddwalls
force-pushed
the
manjari/tango-analyzer-core
branch
from
October 20, 2026 22:58
2f737df to
ce2e132
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The orchestrator has no conflict analyzer that looks at the build graph, so batches touching different files but sharing affected targets run in parallel. The Tango analyzer compares the targets each batch affects, using the signatures, store, cache and request types from the earlier PRs in this stack.
What
Analyzesigns the batch being analyzed (cache, then store, then Tango, created once) and reportsConflictTypeTargetOverlapfor each in-flight batch whose recorded signature shares a target ID.ErrNoSignature) or a store error fails the analysis.SignatureCacheis exported so one cache can be shared across queues. The base revision comes fromParams.BaseRevision, a function returning a commit SHA.TODO(tango)), the base-revision source, a real Tango adapter, and wiring. Nothing constructs the analyzer yet.Test Plan
bazel test //submitqueue/extension/conflict/tango/...CI
Issue